[FSSDK-10316] crypto and text encoder polyfill addition for React native#936
Merged
junaed-optimizely merged 4 commits intomasterfrom Jun 28, 2024
Merged
[FSSDK-10316] crypto and text encoder polyfill addition for React native#936junaed-optimizely merged 4 commits intomasterfrom
junaed-optimizely merged 4 commits intomasterfrom
Conversation
mikechu-optimizely
approved these changes
Jun 28, 2024
Contributor
mikechu-optimizely
left a comment
There was a problem hiding this comment.
I added some nit but LGTM. Thanks for const+let
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cryptomodule is not supported by React native. Our SDK currently throws "crypto.getRandomValues() not available" error. A polyfill has been added to avoid that issue.TextEncodersupport until recently. A polyfill has been added for react-native <= 0.73Test plan
Modified existing React Native test to adjust with the current changes. Existing test should pass
Issues
FSSDK-10316